Target .NET 8, #928 #982
Merged
Target .NET 8, #928 #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RMATTRIBUTE so we don't have an #ifdef hard coded to a specific target framework. This fixes the CA1416 warning after targeting net8.0, and will make future targeting simpler.
…ersioning` and sorted using directives
NightOwl888
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks for the PR.
The changes look good.
This brings us from 93% to 95% of the allowed 10GB on Azure Pipelines, so we are good for now. After #981, this target only brought us from the original distribution size of 127MB up to 130MB.
There was a prior change that hard coded the net6.0 target framework in NativeFSLockFactory which triggered a build warning after the upgrade, which I have addressed in a way that is tolerant of future target framework changes.
This was referenced Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the .NET 8 target.
Fixes #928
Description
This PR adds the .NET 8 target. Due to a conflict between extension methods in .NET 8 and J2N, we added new methods to Collections to create J2N read-only collections instead of using the extension method. The unit tests will use the net8.0 targets when run under .NET 8 now, instead of net6.0.
Additionally, this resolves a warning when running the .NET 5 tests, and ensures the
_artifacts/NuGetPackagesfolder is created in the build script before restore, which is helpful when you add that folder as a local path in your NuGet sources for testing purposes.